Browse Source

Improve ssl cert symlinking

bryan 2 years ago
parent
commit
1803ddd055
1 changed files with 7 additions and 6 deletions
  1. 7 6
      installJRMC

+ 7 - 6
installJRMC

@@ -742,21 +742,22 @@ runCreaterepo() {
 symlinkCerts() {
     debug "Running: ${FUNCNAME[0]}"
 
-    declare mc_cert_link="/usr/lib/jriver/Media\ Center\ $MVERSION/ca-certificates.crt"
-    declare target_cert ln_cmd
+    declare mc_cert_link="/usr/lib/jriver/Media Center $MVERSION/ca-certificates.crt"
+    declare target_cert
+    declare -a ln_cmd
 
     target_cert=$(readlink -f "$mc_cert_link")
 
     [[ -f $target_cert ]] && return 0
 
     if [[ -f /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem ]]; then
-        ln_cmd="sudo ln -fs /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem $mc_cert_link" # For RHEL
+        ln_cmd=("sudo" "ln" "-fs" "/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem" "$mc_cert_link") # For RHEL
     elif [[ -f /var/lib/ca-certificates/ca-bundle.pem ]]; then
-        ln_cmd="sudo ln -fs /var/lib/ca-certificates/ca-bundle.pem $mc_cert_link" # For SUSE
+        ln_cmd=("sudo" "ln" "-fs" "/var/lib/ca-certificates/ca-bundle.pem" "$mc_cert_link") # For SUSE
     fi
     
-    debug "$ln_cmd" || ln_cmd+=" &>/dev/null"
-    if ! eval "$ln_cmd"; then
+    debug "${ln_cmd[*]}"
+    if ! "${ln_cmd[@]}"; then
         err "Symlinking certificates failed"
         return 1
     fi